Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pageserver): vectored get target_keyspace directly accums #8055

Merged
merged 1 commit into from
Jun 14, 2024
Merged

chore(pageserver): vectored get target_keyspace directly accums #8055

merged 1 commit into from
Jun 14, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 13, 2024 •
edited
Loading

Problem

follow up on #7904

Summary of changes

avoid a layer of indirection introduced by Vec<Range<Key>>

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh
chore(pageserver): vectored get target_keyspace directly accums
e78146f 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from VladLazar June 13, 2024 20:52
@skyzh skyzh requested a review from a team as a code owner June 13, 2024 20:52
@github-actions GitHub Actions
Copy link

3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)

Flaky tests (2)

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release

Postgres 15

  • test_pageserver_restarts_under_worload: release

Code coverage* (full report)

  • functions: 31.5% (6635 of 21061 functions)
  • lines: 48.6% (51632 of 106259 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
e78146f at 2024-06-13T21:40:25.799Z :recycle:

VladLazar
VladLazar approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thank you for doing this

@skyzh skyzh merged commit 8189219 into main Jun 14, 2024
63 of 64 checks passed
@skyzh skyzh deleted the skyzh/impr-keyspace-accum branch June 14, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLazar VladLazar VladLazar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @VladLazar